>pull request rejected
Pull request rejected
Jayden Green
Nathaniel Ramirez
>the pull request
>"Added a Code of Conduct"
Jordan Perez
function random_number() {
return 2;
}
>pull request rejected
>reson: no tests
Dominic Hall
>just get done fixing merge conflicts
>someone else's PR gets approved first so you have to start all over
Juan King
git merge -s ours
You're welcome.
Cameron Murphy
>pull request approved
>my shitty code is now on all of your computers, as long as you have systemd
>win and macfags need not apply
You're welcome
Gabriel Thompson
git noob here
let's say i cloned a git, i made no changes, but the master branch has shit tons of updated
what command do I use to update my local clone to the master?
Robert Stewart
git checkout -f
Jack Cook
git pull
Nathaniel Wright
>pull request approved
>immediately reverted by another maintainer who didn't pipe up in the 3 months it was open
Lucas Jones
How do I find a repo to contribute to? Everything already has a ton of help
Grayson Jones
>cute anime girl pfp
I will now accept your pull request.
Henry Rodriguez
>not simply reverting his revert and rebasing your commit
Jackson Brown
shitposting aside one of the most valuable lessons I've learned is not to identify with your work too much. don't be sad when your PR is rejected. it's not an attack on you.
Isaac Cruz
But I worked really hard on it!
Julian Moore
that means one of two things
1. you didn't consult the maintainers first to see if they wanted what you worked on
2. your PR was of poor quality or too large
you can fix both of these things going forward.
Jaxson Murphy
That's the weakest post I've read all day. Just go cower under the table you fucking loser. Assert dominance by force pushing everything.
Eli Diaz
>you didn't consult the maintainers first to see if they wanted what you worked on
It has one maintainer, I'm not gonna ask permission to add features I wanted.
Jason Brown
>I'm not gonna ask permission to add features I wanted
well, you have to if you want it merged. it's their call.
Brandon Mitchell
Well then fuck you i'm forking the repo.
Parker Miller
>reject their PR
>copy paste their code into my project and commit it with my name
If you write open source, you literally have no legal right to complain. :^)
Dylan Kelly
git pull --rebase
but honestly, you shouldn't be making changes in master if you're planning on creating a pull request. do it on a separate branch.
Brody Lopez
>Well then fuck you i'm forking the repo.
That was always allowed